-
Notifications
You must be signed in to change notification settings - Fork 10.5k
preset: treat swift testing the same as xctest #81401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
swiftlang/swift-package-manager#8495 @swift-ci smoke test |
8df6512
to
1d04798
Compare
swiftlang/swift-package-manager#8495 @swift-ci smoke test |
swiftlang/swift-package-manager#8495 @swift-ci smoke test macOS |
Whenever XCtest is build and installed, do the same for swift-testing and swift-testing macros.
1d04798
to
2962ea2
Compare
swiftlang/swift-package-manager#8495 @swift-ci smoke test |
swiftlang/swift-package-manager#8495 @swift-ci smoke test linux |
swiftlang/swift-package-manager#8495 @swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could likely refactor some of this to a testing mixin
[preset: testing_runtimes_mixin]
xctest
swift-testing
swift-testing-macros
But then it's a matter of adding that preset mixin to each of the presets that use it under the mixin-preset
flag.
Up to you.
Adding swift-testing to the second bootstrap stage is probably fine. Ideally we're building as few things in the bootstrap stages since they get thrown away, but I think that the final toolchain stage will use it when running tests on the SwiftPM packages.
Convert `BasicsTests/Environment/*.swift`, `BasicsTests/Graph/*.swift` and a couple other in BasicsTests to Swift Testing Depends on: swiftlang/swift#81401
Whenever XCtest is build and installed, do the same for swift-testing and swift-testing macros so projects can use whichever testing framework.