Skip to content

Correctly fill multiple named parameters with collection #34769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correctly fill multiple named parameters with collection #34769

wants to merge 1 commit into from
+16 −8

Conversation

Dieken
Copy link

@Dieken Dieken commented Apr 16, 2025

Fixes #34768

@Dieken
Correctly fill multiple named parameters with collection
1c4c34c 
Fixes spring-projects#34768

Signed-off-by: Yubao Liu <yubao.liu@gmail.com>
@Dieken Dieken force-pushed the fix-named-parameters-with-collection branch from f348c68 to 1c4c34c Compare April 16, 2025 16:59
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 16, 2025
@sbrannen sbrannen self-assigned this Apr 17, 2025
@sbrannen sbrannen added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Apr 17, 2025
@sbrannen sbrannen mentioned this pull request Apr 17, 2025
Closed
@sbrannen sbrannen assigned sbrannen and unassigned sbrannen May 4, 2025
@sbrannen
Copy link
Member

sbrannen commented May 9, 2025

Hi @Dieken,

As I mentioned in commit dd6eede, I decided to effectively reinstate the original implementation from the Spring Data R2DBC project.

In light of that, I am closing this PR.

Cheers,

Sam

@sbrannen sbrannen closed this May 9, 2025
@sbrannen sbrannen added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R2DBC NamedParameterUtils only expands reused collection parameter once
3 participants
@Dieken @sbrannen @spring-projects-issues