Skip to content

Add Scala 3.3.4 to API links #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _overviews/contribute/guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ This is the impatient developer's checklist for the steps to submit a bug-fix pu
5. [Fix the bug, or implement the new small feature][hackers-implement], include new tests (yes, for bug fixes too).
6. [Test, rinse][hackers-test] and [test some more][partest-guide] until [all the tests pass][hackers-verify].
7. [Commit your changes][hackers-commit] to your feature branch in your fork. Please choose your commit message based on the [Git Hygiene](https://github.com/scala/scala#user-content-git-hygiene) section of the Scala project README.
8. If necessary [re-write git history](https://git-scm.com/book/en/Git-Branching-Rebasing) so that [commits are organized by major steps to the fix/feature](
8. If necessary [re-write git history](https://git-scm.com/book/en/v2/Git-Branching-Rebasing) so that [commits are organized by major steps to the fix/feature](
https://github.com/scala/scala#git-hygiene). For bug fixes, a single commit is requested, for features several commits may be desirable (but each separate commit must compile and pass all tests)
9. [Submit a pull request][hackers-submit].
10. [Work with a reviewer](https://github.com/scala/scala#reviewing) to [get your pull request merged in][hackers-review].
Expand Down
8 changes: 4 additions & 4 deletions _overviews/contribute/hacker-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Hacking Scala begins with creating a branch for your work item. To develop Scala
and [GitHub](https://github.com/). This section of the guide provides a short walkthrough, but if you are new to Git,
it probably makes sense to familiarize yourself with Git first. We recommend

* the [Git Pro](https://git-scm.com/book/en/) online book.
* the [Git Pro](https://git-scm.com/book/en/v2) online book.
* the help page on [Forking a Git Repository](https://help.github.com/articles/fork-a-repo).
* this great training tool [LearnGitBranching](https://pcottle.github.io/learnGitBranching/). One-hour hands-on training helps more than 1000 hours reading.

Expand Down Expand Up @@ -96,7 +96,7 @@ Since in our example, we're going to fix an existing bug
16:39 ~/Projects/scala (master)$ git checkout -b ticket/6725
Switched to a new branch 'ticket/6725'

If you are new to Git and branching, read the [Branching Chapter](https://git-scm.com/book/en/Git-Branching) in the Git Pro book.
If you are new to Git and branching, read the [Branching Chapter](https://git-scm.com/book/en/v2/Git-Branching-Branches-in-a-Nutshell) in the Git Pro book.

### Build

Expand Down Expand Up @@ -333,11 +333,11 @@ Let's go into each of these points in more detail.

### Commit

The [Git Basics](https://git-scm.com/book/en/Git-Basics) chapter in the Git online book covers most of the basic workflow during this stage.
The [Git Basics](https://git-scm.com/book/en/v2/Git-Basics-Getting-a-Git-Repository) chapter in the Git online book covers most of the basic workflow during this stage.
There are two things you should know here:

1. Commit messages are often the only way to understand the intentions of authors of code written a few years ago. Thus, writing a quality is of utmost importance. The more context you provide for the change you've introduced, the larger the chance that some future maintainer understand your intentions. Consult [the pull request policies](https://github.com/scala/scala/blob/2.12.x/CONTRIBUTING.md) for more information about the desired style of your commits.
2. Keeping Scala's git history clean is also important. Therefore we won't accept pull requests for bug fixes that have more than one commit. For features, it is okay to have several commits, but all tests need to pass after every single commit. To clean up your commit structure, you want to [rewrite history](https://git-scm.com/book/en/Git-Branching-Rebasing) using `git rebase` so that your commits are against the latest revision of `master`.
2. Keeping Scala's git history clean is also important. Therefore we won't accept pull requests for bug fixes that have more than one commit. For features, it is okay to have several commits, but all tests need to pass after every single commit. To clean up your commit structure, you want to [rewrite history](https://git-scm.com/book/en/v2/Git-Branching-Rebasing) using `git rebase` so that your commits are against the latest revision of `master`.

Once you are satisfied with your work, synced with `master` and cleaned up your commits you are ready to submit a patch to the central Scala repository. Before proceeding make sure you have pushed all of your local changes to your fork on GitHub.

Expand Down
6 changes: 4 additions & 2 deletions api/all.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ redirect_from:

* Scala 3.5.1
* [Library API](https://www.scala-lang.org/api/3.5.1/)
* Scala 3.3.3 LTS
* [Library API](https://www.scala-lang.org/api/3.3.3/)
* Scala 3.3.4 LTS
* [Library API](https://www.scala-lang.org/api/3.3.4/)
* Scala 2.13.15
* [Library API](https://www.scala-lang.org/api/2.13.15/)
* [Compiler API](https://www.scala-lang.org/api/2.13.15/scala-compiler/scala/)
Expand Down Expand Up @@ -74,6 +74,8 @@ https://scala-ci.typesafe.com/artifactory/scala-integration/org/scala-lang/
* [Library API](https://www.scala-lang.org/api/3.4.1/)
* Scala 3.4.0
* [Library API](https://www.scala-lang.org/api/3.4.0/)
* Scala 3.3.3 LTS
* [Library API](https://www.scala-lang.org/api/3.3.3/)
* Scala 3.3.1 LTS
* [Library API](https://www.scala-lang.org/api/3.3.1/)
* Scala 3.3.0 LTS
Expand Down