Skip to content

chore(architect): update @architect/functions #13556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented May 7, 2025

Re-submission of remix-run/remix#7207

@MichaelDeBoey MichaelDeBoey requested a review from brophdawg11 May 7, 2025 17:28
@MichaelDeBoey MichaelDeBoey added dependencies Pull requests that update a dependency file pkg:@react-router/architect labels May 7, 2025
Copy link

changeset-bot bot commented May 7, 2025

🦋 Changeset detected

Latest commit: 5a497bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/architect Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/cloudflare Patch
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/express Patch
@react-router/node Patch
@react-router/remix-routes-option-adapter Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor

This sounds like a breaking change for existing apps? The v7 release notes state:

Breaking change: default JWE session encryption algorithm is now A256GCM

  • This algorithm offers greater entropy with as good or greater performance in session token encryption / decryption
  • Backwards compatible JWE session encryption is available by adding a truthy env var named ARC_FORCE_LEGACY_JWE_SECRET

@lpsinger
Copy link
Contributor

lpsinger commented May 8, 2025

This sounds like a breaking change for existing apps? The v7 release notes state:

Breaking change: default JWE session encryption algorithm is now A256GCM

  • This algorithm offers greater entropy with as good or greater performance in session token encryption / decryption
  • Backwards compatible JWE session encryption is available by adding a truthy env var named ARC_FORCE_LEGACY_JWE_SECRET

Yes, but the React Router session machinery doesn't use Architect's.

@brophdawg11
Copy link
Contributor

ah ok thanks for clarifying. Can we add a changeset?

@brophdawg11 brophdawg11 removed their request for review May 8, 2025 14:08
@MichaelDeBoey MichaelDeBoey force-pushed the update-architect__functions branch from 93354de to 3290a5d Compare May 8, 2025 14:13
@MichaelDeBoey MichaelDeBoey requested a review from brophdawg11 May 8, 2025 14:13
@brophdawg11 brophdawg11 merged commit e4bd11f into remix-run:dev May 8, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed dependencies Pull requests that update a dependency file pkg:@react-router/architect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants