Skip to content

fix(react-router): fix ClientDataFunctionArgs' context #13552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

fix(react-router): fix ClientDataFunctionArgs' context #13552

merged 3 commits into from
May 8, 2025
+3 −6

Conversation

MichaelDeBoey
Copy link
Member

Probably missed in @brophdawg11's #12941

Closes #13550

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2a3fbab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the fix-ClientDataFunctionArgs-context branch from 89b23d8 to 5cb1f90 Compare May 7, 2025 10:37
@MichaelDeBoey MichaelDeBoey linked an issue May 7, 2025 that may be closed by this pull request
The type definition of the context property of ClientDataFunctionArgs would need to be fixed. #13550
Closed
@MichaelDeBoey MichaelDeBoey force-pushed the fix-ClientDataFunctionArgs-context branch from 5cb1f90 to 70b64e2 Compare May 7, 2025 16:40
@MichaelDeBoey MichaelDeBoey requested a review from brophdawg11 May 7, 2025 16:40
@brophdawg11 brophdawg11 merged commit 3db3e2c into remix-run:dev May 8, 2025
5 checks passed
@MichaelDeBoey MichaelDeBoey deleted the fix-ClientDataFunctionArgs-context branch May 8, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 left review comments

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

Assignees
No one assigned
Labels
CLA Signed feat:typescript pkg:react-router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The type definition of the context property of ClientDataFunctionArgs would need to be fixed.
2 participants
@MichaelDeBoey @brophdawg11