fix(client): bring disableClientInfo option back #2959
Draft
+148
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It disappeared in v5 fixes redis#2958
|
@bobymicroby @htemelski Im not sure if this needs to be done for Sentinel, Cluster as well? |
bobymicroby
reviewed
May 12, 2025
| } | ||
| }); | ||
|
|
||
| this.#queue.addCommand(['CLIENT', 'SETINFO', 'LIB-VER', version],{ |
There was a problem hiding this comment.
I can see why you don't add CLIENT SETINFO inside the handshake - because you need a specific catch error clause just for CLIENT SETINFO. However, I think we should add it to the promises array before calling write so we can return it along with the other promises created during the handshake here as CLIENT SETINFO should be threaded as a "handshake" command.
I think Sentinel and Cluster reuse the handshake logic defined in lib/client/index.ts, so you don't have to do something extra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It disappeared in v5
fixes #2958
Checklist
npm testpass with this change (including linting)?