calculating number of connections to align with v2 metrics, aligning on db / cluster #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
endpoint_client_connectionsmetric that was previously being used for calculating the number of connections is, as it turns out, a counter, so it will never reset after clients exit, because of this it was displaying numbers that are misaligned from the reality for the current number of connections to Redis in the Connections widget in New Relic. This should be a calculation (endpoint_client_connections - endpoint_client_disconnections), This PR buckets them and uses the max within the bucket (max makes sense as this is a counter).I also noticed that the widget was grouping multiple clusters together if they had the same db id (e.g. an A-A database where both clusters had the relevant crdb dbid set to 1 were being combined), hence I added the the
clusterfacet.