Fix #9051: Add integer dtype check to RandomPosterize #9052
Conversation
– Introduce helper _ensure_integer_dtype to validate tensor.dtype via torch.iinfo – Call this helper in RandomPosterize.transform to raise TypeError on non-integer dtypes
– Test that RandomPosterize(bits=3, p=1.0) raises TypeError on float32, bool, complex64 with message “Number of value bits is only defined for integer dtypes” – Test that RandomPosterize(bits=4, p=1.0) successfully processes a uint8 tensor
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9052
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @ion-linti! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
I have signed the CLA. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hi! Waiting for your feedback |
This PR adds a helper function
_ensure_integer_dtypethat usestorch.iinfoto validate that inputs toRandomPosterizeare integer‐typed. InRandomPosterize.transformwe now call this helper to raise a clearTypeErrorwhen passed float, bool, or complex tensors.Additionally, two new pytest cases have been added:
test_random_posterize_dtype_errorverifies that non-integer dtypes (float32, bool, complex64) trigger the expected error message.test_random_posterize_uint8_passconfirms that a uint8 tensor is processed without error and retains its dtype.