Skip to content

fix: removed inject decorator provided by dependency_injector #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XyLearningProgramming
Copy link

Thank you for your amazing project showing an example of ddd pattern.

I found that the @injector decorators are actually not in use. For usages like Annotated[Application, Depends(get_application)], it is FastAPI that solves dependencies by calling this func directly: source code here.

If you'd like to use dependency-injector directly with FastAPI, according to this doc, the dependent should be formalized with dependency_injector.Provide as Depends(Provide[ApplicationContainer.application]) or Depends(Provide["application"]).

This PR removed @injector decorators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant