improve error handling in webRTC-related noise function #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43 This PR:
Multiaddr
. Ensures litep2p behaves predictably even with malformed or malicious peers during the handshake phase by introducingInvalidMultihash
in theAddressError
.reply
buffer size, by checking the length before splitting inget_remote_public_key
function.I am also looking at other functions to see if there should be any improvement, i will make this a draft PR untill i finish other improvements or if i find no other improvements needed.