Skip to content

improve error handling in webRTC-related noise function #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dharjeezy
Copy link
Contributor

@dharjeezy dharjeezy commented Apr 22, 2025

Closes #43 This PR:

  • eliminates the unsafe assumption and panics in the WebRTC litep2p config when fetching Multiaddr. Ensures litep2p behaves predictably even with malformed or malicious peers during the handshake phase by introducing InvalidMultihash in the AddressError.
  • removes assumption about the reply buffer size, by checking the length before splitting in get_remote_public_key function.

I am also looking at other functions to see if there should be any improvement, i will make this a draft PR untill i finish other improvements or if i find no other improvements needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling in WebRTC-related Noise functions
1 participant