feat(rpc): specialise contiguous receipt queries for logs #16441
+271
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
C-enhancement
mattsse
requested changes
May 23, 2025
crates/rpc/rpc/src/eth/filter.rs
Outdated
|
|
||
| // cache miss - fallback to storage to ensure correctness | ||
| if let Some(receipts) = | ||
| self.filter_inner.provider().receipts_by_block(block_hash.into())? |
There was a problem hiding this comment.
we have this fn
reth/crates/storage/provider/src/providers/database/mod.rs
Lines 515 to 518 in badbe3d
which I think we could adapt to return Vec of Vec for blocks as well this would likely be more efficient for entire block ranges
There was a problem hiding this comment.
makes sense, will prepare a separate PR for this
fgimenez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16437
RangeModeenum withCachedandRangevariants and types associated to eachCachedvariant and specialization, fetching blocks from the cache (falling back to storage on miss)