Skip to content

DO NOT MERGE: add native packed nibbles representation #16239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: main
Choose a base branch
from
Draft

DO NOT MERGE: add native packed nibbles representation #16239

wants to merge 53 commits into from

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented May 14, 2025 •
edited
Loading

Towards #15594

Minimal methods for a packed nibbles representation, will close and add to alloy-rs/nybbles if successful

Rjected and others added 13 commits May 8, 2025 22:13
@Rjected
feat(trie): add native packed nibbles representation
dd89e3b
@shekhirin
refactor(trie): simplify PackedNibbles logic, add more comments
080a911
@shekhirin
feat(trie): packed nibbles abomination
b62c349
@shekhirin
wip
ba71436
@shekhirin
fix(trie): inconsistencies between low/high nibbles in PackedNibbles
1cbc216
@shekhirin
fix(trie): Ord implementation of PackedNibbles and `PackedNibbles…
ecaa602 
…::extend_path`
@shekhirin
docs(trie): TODO: optimize comments for PackedNibbles
d3965c1
@shekhirin
test(trie): fix most of the sparse trie tests
7276b55
@shekhirin
perf(trie): improve the implementation of Ord for PackedNibbles
f978f72
@shekhirin
fix(trie): Ord implementation for PackedNibbles
bb78f05
@shekhirin
refactor(trie): use zip in Ord implementation of PackedNibbles
9afc823
@shekhirin
perf(trie): optimize PackedNibbles::starts_with
7d6f479
@shekhirin
refactor(trie): introduce CAPACITY_BYTES constant for PackedNibbles
5e8c3dd
@shekhirin shekhirin added C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels May 14, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker May 14, 2025
@shekhirin shekhirin mentioned this pull request May 14, 2025
Closed
@shekhirin shekhirin force-pushed the alexey/packed-nibbles branch from d5ab43f to e26cee5 Compare May 14, 2025 18:29
@shekhirin shekhirin force-pushed the alexey/packed-nibbles branch from ba5d99b to f84e721 Compare May 14, 2025 22:12
@shekhirin shekhirin force-pushed the alexey/packed-nibbles branch from ed0d4a4 to 8feacfc Compare May 16, 2025 18:58
shekhirin added 26 commits May 19, 2025 20:12
@shekhirin
perf(trie): optimize PackedNibbles::common_prefix_length
653d766
@shekhirin
revertme: benchmark to demonstrate clone in smallvec vs tinyvec
8bb7e2e
@shekhirin
revertme: black box
dbd5885
@shekhirin
revertme: black box properly
dfccc87
@shekhirin
fix(trie): PackedNibbles::common_prefix_length
a3b7d0c
@shekhirin
test(trie): PackedNibbles::common_prefix_length
7a85921
@shekhirin
revertme: core::ptr::read
7e367cf
@shekhirin
Revert "revertme: core::ptr::read"
8856249 
This reverts commit 7e367cf.
@shekhirin
remove benchmark
2cdd953
@shekhirin
perf(trie): repr(C) for PackedNibbles
a8b3d54
@shekhirin
bench(trie): cleanup benchmarks
1d458e0
@shekhirin
perf(trie): use U256 as repr for PackedNibbles (WIP)
eb591a5
@shekhirin
perf(trie): PackedNibbles::slice
f04e5b4
@shekhirin
perf(trie): PackedNibbles::slice and
bd0497d 
`PackedNibbles::common_prefix_length`
@shekhirin
perf(trie): static masks for PackedNibbles::slice
d42845b
@shekhirin
refactor(trie): move shift right bits to a variable in
caef59a 
`PackedNibbles::starts_with`
@shekhirin
bench(trie): PackedNibbles::push_unchecked
e347af1
@shekhirin
bench(trie): black box inputs
282dcb0
@shekhirin
perf(trie): do not mask in PackedNibbles::starts_with
59e64e9
@shekhirin
refactor(trie): reorder methods
5e6e52c
@shekhirin
bench(trie): different percentages in PackedNibbles::starts_with
75f6063
@shekhirin
perf(trie): PackedNibbles::starts_with
20d966c
@shekhirin
perf(trie): different optimizations
48d9029
@shekhirin
chore(trie): more const methods
00b4c3c
@shekhirin
perf(trie): do not shift when not needed in slice
1815345
@shekhirin
docs(trie): cleanup tests and comments
4e443a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk will be requested when the pull request is marked ready for review rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected will be requested when the pull request is marked ready for review Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez will be requested when the pull request is marked ready for review fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
Reth Tracker
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @Rjected