Skip to content

fix duplicated labels in metaflow ui static deployment #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jfmrm
Copy link

@jfmrm jfmrm commented Feb 25, 2025

in helpers.tpl there are 2 labels definitions, one for backend and another for static components, but the static labels were including backend labels, which lead to label duplication and therefore installation not being successful. Here is a before/after from the static_deployment labels:

before:

# Source: metaflow-ui/templates/static_deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: "metaflow-ui-static"
  labels:
    helm.sh/chart: metaflow-ui-0.3.0
    app.kubernetes.io/name: metaflow-ui
    app.kubernetes.io/instance: metaflow-ui
    app.kubernetes.io/version: "v2.4.13"
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: metaflow-ui-static
    app.kubernetes.io/instance: metaflow-ui
    app.kubernetes.io/version: "v2.4.13"
    app.kubernetes.io/managed-by: Helm

after:

---
# Source: metaflow-ui/templates/static_deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: "release-name-metaflow-ui-static"
  labels:
    app.kubernetes.io/name: metaflow-ui-static
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v2.4.13"
    app.kubernetes.io/managed-by: Helm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant