-
Notifications
You must be signed in to change notification settings - Fork 779
Mercurial history per partes #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good! Awesome job! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts Mercurial history handling to the per partes style done in #3589 for Git.
In Mercurial I happen to be using (5.3.1) the revision filtering for file history log is still broken, i.e.
hg log -r X:Y --follow <file>
does not display expected list of changesets. This is only relevant to renamed file handling. I strip the unwantedHistoryEntry
objects as a workaround. Even if it worked, it would be probably unusable - thinking the revision filtering for files works, I tried it first and it resulted in some of thehg
processes to consume over 12 GB RSS and the system got into unhappy place (heavy swapping, the OOM killer striking).The history cache was much slower to generate with the repository I tried this on (OpenSolaris ON gate with some 16k changesets, the majority of files added in the first changeset), like 4 minutes vs. 10 minutes (renamed handling on, 8 GB heap), however I think this is partly due to the fact that the history cache for renamed files is generated in parallel (there are some 2800 renamed files there) and for the regular files still sequentially (#3542).