Fix nix run and nix develop by using pnpm-lock.yaml #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
scanhex
commented
May 20, 2025
Comment on lines
-52
to
-54
| defaultPackage = packages.codex-cli; | ||
| defaultApp = apps.codex-cli; | ||
| defaultDevShell = devShells.codex-cli; |
There was a problem hiding this comment.
nix run doesn't pick up the codex-cli dev shell this way, looks like it's outdated.
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the flakes for codex-cli are broken right now,
nix run github:openai/codexdoesn't work because package-lock.json is missing.In this PR I'm making the nix flake use pnpm-lock.yaml instead. This makes
nix run github:scanhex/codexrun fine - and fixes the same issue withnix develop.