fix: Initialize environment variables for the active non-OpenAI provider #1012
+54
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where API keys and other necessary environment variables were not loaded for non-OpenAI providers. The application now correctly reads the environment variables specific to the selected provider during startup.
Allows users to choose an alternative provider (e.g. Azure, Ollama) from the initial API-key dialog. Selecting this option: • generates ~/.codex/config.json via loadConfig/saveConfig so the file exists • switches UI to an exit screen instructing the user to edit the config • exits the process shortly after so the user can restart Codex The step union is extended to include 'exit' and the select handler updated to switch on item.value for clearer logic.
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #975
This PR addresses issue #975 by correcting an initialization problem for non-OpenAI providers. It also adds a new option to the initial setup prompt to guide users who wish to configure alternative providers (e.g., Azure) via the
~/.codex/config.jsonfile, aiming to make this process more straightforward for newcomers.For instance, when I first tried to use Azure, I followed the README using the
--provideroption, but was still prompted for OpenAI login, which was a bit confusing. This new prompt option is intended to prevent such initial hurdles.Similar improvements may have been addressed in PR #990. If that PR sufficiently covers the necessary changes, please feel free to close this one.