Skip to content

1.32 dev #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 52 commits into
base: 1.25
Choose a base branch
from
Open

1.32 dev #49

wants to merge 52 commits into from

Conversation

tmahmood
Copy link

@tmahmood tmahmood commented May 1, 2023

Hey @octaltree

I have updated playwright-rust to version 1.32-beta, and all the tests are passing, and I have not faced any issues in regular usages.

Additionally, I have replaced Mutex/MutexGuard with parking_lot

Please review and merge.

Thanks :-)

Tarin Mahmood and others added 21 commits August 20, 2022 21:29
Added commit Document state
4a72d5a
Using LifecycleEvent
e7a8ada
Using LifecycleEvent
a81c7a1
playwright can return response without any params which would break…
8088b0d 
… the deserializer. Adding serde default to the `params` field resolves that
Fixed Page Events not detected correctly
82c59b9 
1. Load
2. DOMContentLoaded
3. Request
4. Response
@octaltree
Merge pull request octaltree#35 from tmahmood/dev
7768d0b 
Small changes to make the tests run (Not all tests are passing)
@octaltree
tmp
3960388
@tmahmood
Update utils.rs
48b9788 
Added mime_type
Added mime_type to File structure.
e934041
Large file upload api is now implemented. It does not replace the exi…
c7210d8 
…sting file upload api. Which works upto 100MB

Will not work for remote playwright server. We can continue work on it later
Fixed issue with not being able to spawn multiple playwright instances.
a4c4073
Fixed issue with not being able to spawn multiple playwright instances.
153494f
Merge branch '1.25' into dev
9e97665 
# Conflicts:
#	scripts/Makefile
#	scripts/src/api.rs
#	scripts/src/generate_api.rs
#	src/imp/playwright.rs
#	src/protocol/generated.rs
@tmahmood
Updated ConsoleMessage Structure to match with latest playwright version
cdeabd2 
ConsoleMessage structure was changed, which caused playwright to fail if there was any console messages.
@tmahmood
Incorporated Randall's Windows Related Changes
cde0f1c
@tmahmood
Update playwright version to: 1.31.0-alpha-feb-1-2023
8e5e8d6 
Updated files required to update protocol
Fixed issue with press
Updated to latest 1.25 and fixed issue with not being able to spawn multiple playwright instances
@tmahmood
Fixed: When using persistent_context_launcher `set_input_file_paths…
d4cd5ea 
…` panicked as browser is None. Now checking if browser is actually set.
@tmahmood
Incorporated Randall's Windows bug fix
27e1401
@tmahmood
Updated ConsoleMessage Structure to match with latest playwright version
03d2970 
ConsoleMessage structure was changed, which caused playwright to fail if there was any console messages.
@tmahmood
Updated connection.rs to fix parking_lot related issue
836ddbc
@tmahmood
Update github action, using nightly
9425bc3
@tmahmood tmahmood changed the base branch from master to 1.25 May 1, 2023 14:28
@d4h0
Copy link

d4h0 commented May 26, 2023

Hi @tmahmood,

First of all, thank you so much for your work on updating playwright-rust!

I'm thinking about porting my current chromiumoxide-based code to playwright-rust, and I have a few questions (I hope it's okay that I ask them here. Issues seem to be closed on your fork).

(1) I'm wondering if you intend to continue to (help to) maintain this crate (it wouldn't make sense, to switch to playwright-rust, if it will be outdated in a few months again).

If I remember correctly, @octaltree isn't using playwright-rust anymore himself, so it's completely understandable that he doesn't want to/can't spend too much time on it.

(2) Because you probably have a good understanding now, regarding how playwright-rust works, I'm wondering if there is any chance that you'd create (more) documentation about how to update/maintain it.

I tried a few times to get playwright usable from Rust, but (because of time-constraints) I wasn't able to finish anything, yet.

(So far I've tried to update playwright-rust, to create my own bindings via Node.js or Deno, to create Wasm bindings and use playwright from Wasm executing in Node.js).

I think, with such documentation it would be much easier for other interested people (to which I count myself) to contribute to playwright-rust, and help to keep it up-to-date.

Thanks again, for your work!

@tmahmood
Copy link
Author

Hey, @d4h0 ,

Glad to be of help 🙂

I can get some documentation up for upgrading. And I'll try to keep it uptodate regularly. But not sure how long I can continue

@d4h0
Copy link

d4h0 commented May 28, 2023

Thanks, @tmahmood, that sounds great!

@srid srid mentioned this pull request Aug 2, 2023
Closed
@SamuelMarks SamuelMarks mentioned this pull request Oct 31, 2023
Open
@coopbri coopbri mentioned this pull request Jan 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmahmood @d4h0 @octaltree