-
Notifications
You must be signed in to change notification settings - Fork 1.2k
OCaml 5.4.0: packages for the first alpha #27915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @Octachron Thanks for the contribution. Here are the errors from the pipeline:
I'll try to add some suggestions in order to fix those |
I also think some of those may be false positives, just like here: #27613 @shonfeder @mseri please, take a look when you have a moment |
I'm not exactly sure but considering you want to publish ocaml.5.4.0, you probably need to remove the Otherwise, you'd have to rename the package into |
None of those linter hint apply to compiler packages:
This is intended, the source is defined by the
The compiler is not built with dune, and thus has no dependencies on dune.
Using this flag is intended too. |
Right. That's what I was thinking, tbh. And that's exactly parts outlined in #27613 May I ask why compiler packages are different and linter hints do not apply, so I get a better understanding? |
It's more that the linter doesn't either have more complex interpretations of the rules or, possibly more for these, exceptions embedded in it for these packages. |
This looks OK to me! Thanks for the review @ivnhk and for the explanations @dra27 and @Octachron. LMK when you are happy with this and I will merge it in. re: the false positives on the linting checks, I've opened ocurrent/opam-repo-ci#434 |
Looks good, thanks! We'll need to patch ocaml-version as well now to get the CI kicking in for this. |
This PR adds the three usual packages for the first alpha release of OCaml 5.4.0:
and it amends the
ocaml
metapackage to allow to install the prerelease versions of ocaml-base-compiler.5.4.0~... .