Skip to content

OCaml 5.4.0: packages for the first alpha #27915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025

Conversation

Octachron
Copy link
Member

This PR adds the three usual packages for the first alpha release of OCaml 5.4.0:

  • ocaml-compiler.5.4.0~alpha1
  • ocaml-base-compiler.5.4.0~alpha1
  • ocaml-variants.5.4.0~alpha1+options

and it amends the ocaml metapackage to allow to install the prerelease versions of ocaml-base-compiler.5.4.0~... .

@ivnhk
Copy link

ivnhk commented May 23, 2025

Hey @Octachron

Thanks for the contribution.

Here are the errors from the pipeline:

Error in ocaml-variants.5.4.0~alpha1+options: No package source directory provided.
Warning in ocaml-compiler.5.4.0~alpha1: The package has a dune-project file but no explicit dependency on dune was found.
Error in ocaml-base-compiler.5.4.0~alpha1: No package source directory provided.
Error in ocaml.5.4.0: conf packages should always use the 'conf-' name prefix, the 'conf' flag, and the 'depext' field all together, but this package only has the 'conf' flag

I'll try to add some suggestions in order to fix those

@ivnhk
Copy link

ivnhk commented May 23, 2025

I also think some of those may be false positives, just like here: #27613

@shonfeder @mseri please, take a look when you have a moment

@ivnhk
Copy link

ivnhk commented May 23, 2025

I'm not exactly sure but considering you want to publish ocaml.5.4.0, you probably need to remove the conf flag.

Otherwise, you'd have to rename the package into conf-ocaml and add depexts: [ "ocaml" ]. I don't think that something you're aiming for

@Octachron
Copy link
Member Author

Octachron commented May 23, 2025

None of those linter hint apply to compiler packages:

  • Error in ocaml-variants.5.4.0~alpha1+options: No package source directory provided
  • Error in ocaml-base-compiler.5.4.0~alpha1: No package source directory provided.

This is intended, the source is defined by the ocaml-compiler package in order to avoid duplicating the complex build configuration.

  • Warning in ocaml-compiler.5.4.0~alpha1: The package has a dune-project file but no explicit dependency on dune was found.

The compiler is not built with dune, and thus has no dependencies on dune.

  • Error in ocaml.5.4.0: conf packages should always use the 'conf-' name prefix, the 'conf' flag, and the 'depext' field all together, but this package only has the 'conf' flag

Using this flag is intended too.

@ivnhk
Copy link

ivnhk commented May 23, 2025

Right. That's what I was thinking, tbh. And that's exactly parts outlined in #27613

May I ask why compiler packages are different and linter hints do not apply, so I get a better understanding?

@dra27
Copy link
Member

dra27 commented May 23, 2025

It's more that the linter doesn't either have more complex interpretations of the rules or, possibly more for these, exceptions embedded in it for these packages.

@shonfeder
Copy link
Contributor

This looks OK to me! Thanks for the review @ivnhk and for the explanations @dra27 and @Octachron.

LMK when you are happy with this and I will merge it in.

re: the false positives on the linting checks, I've opened ocurrent/opam-repo-ci#434

@avsm avsm merged commit 20fc22d into ocaml:master May 24, 2025
1 of 2 checks passed
@avsm
Copy link
Member

avsm commented May 24, 2025

Looks good, thanks! We'll need to patch ocaml-version as well now to get the CI kicking in for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants