Skip to content

Create opam conf-file for povray #27890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

fccm2
Copy link

@fccm2 fccm2 commented May 16, 2025

just runs which povray to check if it's installed on the system

@jmid
Copy link
Contributor

jmid commented May 17, 2025

Thanks! 🙏

I can see povray is also available on

just runs which povray to check if it's installed on the system

This in turn depends on which which may not be available, say on Windows.

Instead the consensus seems to be to run the command directly with a suitable option (say --version) if such a thing exists (I don't think it does from a quick skim of https://manpages.debian.org/experimental/povray/povray.1.en.html however), or test with the POSIX compatible command -v <program-name>. For more details see #18452.

which seems to not be available on windows, so let's switch to use the --version command line option
@fccm2
Copy link
Author

fccm2 commented May 17, 2025

Indeed it is not mentioned in the man page, but the option exists. (this option is mentioned when we do -help)
Let's switch to it then.

Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
@shonfeder
Copy link
Contributor

Looks like the build recipe on freebsd does not work out of the box:

https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/92e1b8bba18da3cbba88037f7ff174d78c001f64/variant/freebsd,freebsd-14.2-ocaml-4.14-amd64,conf-povray.1

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><><><>
[ERROR] The compilation of conf-povray.1 failed at "sh -c povray --version".

#=== ERROR while compiling conf-povray.1 ======================================#
# context              2.3.0 | freebsd/x86_64 | ocaml-base-compiler.4.14.2 | pinned
# path                 ~/.opam/4.14.2/.opam-switch/build/conf-povray.1
# command              /bin/sh -c povray --version
# exit-code            127
# env-file             ~/.opam/log/conf-povray-75267-a06ff4.env
# output-file          ~/.opam/log/conf-povray-75267-a06ff4.out
### output ###
# /bin/sh: povray: not found

Any ideas what may be needed here?

@jmid
Copy link
Contributor

jmid commented May 21, 2025

Any ideas what may be needed here?

Yep, the binary is named differently. See my latest change suggestion above.

Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
@shonfeder
Copy link
Contributor

Thanks @jmid !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants