enhance: replace memory uuids with increasing positive integers #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2025
g-linville
approved these changes
Apr 30, 2025
| // NextMemoryID is a string representation of a monotonically increasing positive integer used | ||
| // to generate unique IDs for new memories. | ||
| // This field MUST be used as the ID of the next memory added to the MemorySet. | ||
| // After a memory is added, this field MUST be incremented by 1 when a new memory is add. |
There was a problem hiding this comment.
nit
Suggested change
| // After a memory is added, this field MUST be incremented by 1 when a new memory is add. | |
| // After a memory is added, this field MUST be incremented by 1 when a new memory is added. |
| return big.NewInt(0) | ||
| } | ||
|
|
||
| // Increment the largets valid ID to get the next memory ID |
There was a problem hiding this comment.
nit
Suggested change
| // Increment the largets valid ID to get the next memory ID | |
| // Increment the largest valid ID to get the next memory ID |
Refactor the memory API to produce monotonically increasing positive integers for memory IDs instead of using UUIDs. Signed-off-by: Nick Hale <4175918+njhale@users.noreply.github.com>
njhale
force-pushed
the
enhance-memory-no-uuids-2
branch
from
7bc546d to
3c26cac
Compare
tybalex
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the memory API to produce monotonically increasing positive integers for memory IDs instead of using UUIDs.