feat(lint): use ESLint for linting snippets

[avivkeller]

Description

This PR replaces our custom snippet linting logic with MDX's lintCodeBlocks option.

Validation

Linting should pass

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run pnpm format to ensure the code follows the style guide.
• I have run pnpm test to check if all tests are passing.
• I have run pnpm build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 9, 2025 10:25pm

[github-actions]

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

[Copilot]

Pull Request Overview

This PR refactors our code snippets by replacing custom linting logic with MDX’s built‐in lintCodeBlocks option, while also updating variable declarations from var to const/let and reordering some imports.

• Replace custom snippet linting with MDX’s lintCodeBlocks
• Switch from var to const/let in multiple code examples
• Reorder and adjust import statements in several release and documentation pages

Reviewed Changes

Copilot reviewed 46 out of 48 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
apps/site/pages/en/learn/asynchronous-work/dont-block-the-event-loop.md	Convert variable declarations to const and improve logging
apps/site/pages/en/learn/asynchronous-work/discover-promises-in-nodejs.md	Use const for promise executor variables
apps/site/pages/en/learn/asynchronous-work/asynchronous-flow-control.md	Remove unnecessary ESLint disable comments; use const in loops
apps/site/pages/en/blog/release/*.md	Reorder and adjust import statements and update logging output
apps/site/pages/en/blog/module/service-logging-in-json-with-bunyan.md	Replace var with const; update logging usage/comments
apps/site/pages/en/blog/feature/streams2.md	Replace var with const; modernize event handler callbacks
apps/site/pages/en/blog/community/domain-postmortem.md	Replace var with let and update loop declarations; update error handling comments
apps/site/pages/en/blog/announcements/v20-release-announce.md	Reorder import statements to reflect recommended ordering
apps/site/next.mdx.plugins.mjs	Remove redundant comments in plugin definitions
apps/site/eslint.config.js	Add MDX remark processor configuration and mdx.flatCodeBlocks setting

Files not reviewed (2)

• apps/site/package.json: Language not supported
• apps/site/pages/en/index.mdx: Language not supported

Comments suppressed due to low confidence (1)

apps/site/pages/en/blog/community/domain-postmortem.md:194

• Consider using Buffer.alloc(FILESIZE) instead of Buffer(FILESIZE) for enhanced memory safety.

const buf = Buffer(FILESIZE);

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.84%. Comparing base (10a07a1) to head (c591cc5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7720   +/-   ##
=======================================
  Coverage   74.84%   74.84%           
=======================================
  Files          98       98           
  Lines        7888     7888           
  Branches      200      200           
=======================================
  Hits         5904     5904           
  Misses       1983     1983           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[araujogui]

LGTM

[ovflowd]

LGTM! Just double check all snippets to verify we didn't lose things.

[avivkeller]

Note that the snippets on the main page are no longer uniformly 14 lines after this PR. If that's a problem, I can add an additional comment to the 13-lined snippet to make them uniform again.

[ovflowd]

Note that the snippets on the main page are no longer uniformly 14 lines after this PR. If that's a problem, I can add an additional comment to the 13-lined snippet to make them uniform again.

Let's open another issue for that, I feel we can change the CSS so the width/height of all code tabs becomes the width/height of the largest one; I recall CSS grid/flexboxes support something like that. Can I create a follow-up issue for this?

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟠 83	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[avivkeller]

Looks like I got some errors to review, will do!

[avivkeller]

@nodejs/web-infra This doesn't really concern the other groups, so I doubt they will review. Can we merge without them?

[avivkeller]

I've enabled auto-merge. Please merge when ready, with or without additional reviews.

[avivkeller]

Bump @nodejs/releasers @nodejs/security-wg

[richardlau]

Bump @nodejs/releasers

I'm concerned that a number of release posts have been updated in this PR, which suggests that this is going to be using different linting rules than in nodejs/node (since we lint the changelogs there and the release posts are generated from those).

[avivkeller]

Thanks! Ill update the globs to only match learn articles

[UlisesGascon]

Changes in Security best practices are ok for me 👍

[ovflowd]

Bump @nodejs/releasers

I'm concerned that a number of release posts have been updated in this PR, which suggests that this is going to be using different linting rules than in nodejs/node (since we lint the changelogs there and the release posts are generated from those).

@avivkeller did you address this comment?

[avivkeller]

Yes. I changed the glob to skip blog posts.