Skip to content

feat(editor): Preserve workflow list sort & page size preferences #15101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 6, 2025
Merged

feat(editor): Preserve workflow list sort & page size preferences #15101

merged 11 commits into from
May 6, 2025
+520 −69

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented May 5, 2025 •
edited
Loading

Summary

Saving user set values for sorting and page sizes between projects.
Other changes:

  • Add all sort & pagination update so single event payload
  • Removed some excessive watchers from ResourceListLayout component
  • Centralized all local storage logic in useN8nLocalStorage composable

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-3397

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this May 5, 2025
mrge-io[bot]
mrge-io bot reviewed May 5, 2025
View reviewed changes
Copy link

@mrge-io mrge-io bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mrge found 5 issues across 4 files. View them in mrge.io

@codecov Codecov
Copy link

codecov bot commented May 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 49.69325% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...-ui/src/components/layouts/ResourcesListLayout.vue 13.04% 80 Missing ⚠️
...frontend/editor-ui/src/components/TagsDropdown.vue 50.00% 1 Missing ⚠️
...ges/frontend/editor-ui/src/views/WorkflowsView.vue 94.11% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 5, 2025
@MiloradFilipovic MiloradFilipovic force-pushed the ADO-3397-save-sort-and-pagination-to-localstorage branch from f2852d5 to f380b17 Compare May 5, 2025 11:02
@MiloradFilipovic MiloradFilipovic force-pushed the ADO-3397-save-sort-and-pagination-to-localstorage branch from 41a6f58 to 0f2d312 Compare May 6, 2025 07:49
CharlieKolb
CharlieKolb reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments, looks great overall! Love the useN8nLocalStorage composable!

Will test before daily sync

packages/frontend/editor-ui/src/components/layouts/ResourcesListLayout.vue
if (rowsPerPage.value !== props.customPageSize) {
// Only update sort & page size if they are different from the default values
// otherwise, remove them from the query
if (rowsPerPage.value !== preferredPageSize.value) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get weird if two users with different preferences share links? Do we care about supporting this?

Copy link
Contributor Author

@MiloradFilipovic MiloradFilipovic May 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but Nik and Rob confirmed that url values should update your local preferences

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url keeping the newly chosen option (which is now default) while dropping the previous one is killing me a bit, but if you're happy I'm happy :D

Screen.Recording.2025-05-06.at.15.41.08.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too happy to be honest, but I think it makes sense in a way. Let's see the feedback once it gets on internal and we can update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, nothing to block release anyway

CharlieKolb
CharlieKolb previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@CharlieKolb CharlieKolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit cf03a28 into master May 6, 2025
60 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3397-save-sort-and-pagination-to-localstorage branch May 6, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieKolb CharlieKolb CharlieKolb approved these changes

@mrge-io mrge-io[bot] mrge-io[bot] left review comments

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiloradFilipovic @CharlieKolb