Fix bone related functions #4203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
reviewed
May 7, 2025
| CEntity* theEntity = entity->GetGameEntity(); | ||
| if (!theEntity) | ||
| if (bone < BONE_ROOT || bone > BONE_LEFTBREAST) | ||
| throw std::invalid_argument("Invalid bone: " + std::to_string(bone)); |
There was a problem hiding this comment.
The exceptions make functions backward incompatible. Because the existing code can rely on return value, but exceptions will interrupt the execution and potentially break the code. Maybe better to use ArgumentParserWarn<false, ...>?
FileEX
reviewed
May 7, 2025
| return false; | ||
| return theEntity->SetBonePosition(static_cast<eBone>(boneId), position); | ||
|
|
||
| return std::make_tuple(position.fX, position.fY, position.fZ); |
There was a problem hiding this comment.
If you used CLuaMultiReturn in the function definition in the variant, then why are you returning a plain std::tuple here instead of CLuaMultiReturn? Even though CLuaMultiReturn is std::tuple, the return type should match the definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes functions related to bones, until now, 201, 301 and 302 were not useable. Also refactors the mentioned functions.