Skip to content

Enhancement(Add Storybook) #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: v2-dev
Choose a base branch
from
Draft

Conversation

vhrmo
Copy link

@vhrmo vhrmo commented May 5, 2025

Proposed changes

Hi, this is an example of how a Storybook can be used in this project. We use it heavily for our development and it offers great features:

  • live preview of the components during development + light & dark theme
  • ablity to document components in MDX
  • allows for scripted 'play' tests similar to Jasmine
  • allow to use chromatic to compare visual changes

Please check this and let me know what you think about it.

Screenshots (if appropriate) or codepen:

Preview of button stories to test as many as possible configurations:

image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wuda-io
Copy link
Member

wuda-io commented May 7, 2025

Looks very helpful for devlopment and testing. I have not tried it yet but it looks promising. We should definitely implement this. 👍 nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants