-
Notifications
You must be signed in to change notification settings - Fork 549
[CI] Enable building StableHLO in CI #4170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
What about patching StableHLO instead of applying a patch as part of the build? |
Upstream is currently unable to update the dependent LLVM to the latest version due to some blocking issues openxla/stablehlo#2788. This results in version differences between the LLVM used by upstream and the one we are using, which leads to compilation problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm not sure if this is the right approach to fix this issue. I have never seen any such patch before where we're directly modifying an external repo inside the project. If the issue is not fixed upstream, then why not wait for some more time?
I strongly agree as this adds an additional maintenance burden to torch-mlir. Is there any strong reason why this cannot be added to StableHLO upstream? |
This patch file can be removed after the two upstream PRs are merged |
Let's wait for those upstream PRs to be merged and then directly do a bump instead of modifying an external repo. |
Context: Due to the LLVM version upgrade, stablehlo CI tests have been temporarily disabled.
Ref link of discussion: #4152
Content of the current PR: The stablehlo version has been updated, but there are still compilation issues. The main reason is that stablehlo’s LLVM cannot be updated to the latest version for now, so it cannot stay in sync with torch-mlir. Therefore, I have added a patch file to fix some API differences. This does not affect functionality. The patch is temporary and is intended to help restore CI testing for the stablehlo backend as soon as possible.