Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add more support for different workload types #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add more support for different workload types #1052
Changes from all commits
1261213
b26540f
9fd7c56
2ca3af3
ba8220f
ea4b487
72af1fe
d6c2fd3
875b519
47a80db
77b2227
34dd76d
4c7f7e7
cabd525
1ea1d15
728a650
8136869
50e2b75
b1236a3
2a7cd1d
76cf7ae
c6bcfa0
6652520
ac59da1
3a9dc6b
2b6a802
63ef815
453d418
b5c9ff1
c00d26b
0b29b38
5ce6db9
1337481
4050347
278cd4f
bc237b6
f0ba0a8
2589e66
bc2cd2f
1550cc9
09e9c43
57ec738
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jobs with
owner_kind="Pod"
would always be excluded by both this rule and thejob
rule.What should we do with
kube_job_owner{owner_kind="Pod"}
series so that they're not excluded? These appear to be jobs created by pods...