Skip to content

Update app.component.css #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update app.component.css #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions projects/app1/src/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
* {
background-color: red;
}

div {
background: green;
}
Comment on lines +1 to +7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: It's a good practice to use hex color codes instead of color names for better control over the color shades. Also, it's recommended to use 'background-color' instead of 'background' for better readability and specificity.

Suggested change
* {
background-color: red;
}
div {
background: green;
}
* {
background-color: #FF0000;
}
div {
background-color: #008000;
}


.test {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Empty CSS rulesets should be avoided. If the '.test' class is not being used, consider removing it.

Suggested change
.test {}