-
-
Notifications
You must be signed in to change notification settings - Fork 45
WIP: Modular validation in teal
and teal_modules
#1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
averissimo
wants to merge
51
commits into
main
Choose a base branch
from
1322_validation@main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+532
−456
Draft
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
da34ae4
feat: manual modules
averissimo 738dd69
feat: stable factory creation
averissimo b6b72aa
broken: shinysilent not triggering
averissimo 2527887
fix: problem with shiny.silent.error id name
averissimo 9708385
chore: cleanup
averissimo 4ec7ef6
chore: rename ongoing
averissimo 26e9624
chore: remove null coalesce operator that is no longer used
averissimo 4d25b08
chore: cleanup
averissimo ef5859f
chore: adds comments and remove single factory function
averissimo f8d9ea4
chore: remove print statements
averissimo b9ddaee
visual: cleanup and better messages
averissimo abe4a18
style: improve look of messages using blockquote and em
averissimo 7ebaa4e
chore: remove extra comments and functions
averissimo ccd78f6
feat: cleanup
averissimo 4a8bfaa
cleanup: comment cleanup
averissimo c99f7df
cleanup: move module factory to bottom of file
averissimo 7f9c79c
cleanup: re-generate docs
averissimo efb2c80
style: minor corrections and converts to bslib
averissimo e3c4c63
feat: abstract validation UI function
averissimo 4f15db5
feat: unifying
averissimo 508ad4f
cleanup: remove unused code
averissimo 8a4caf7
cleanup: minor
averissimo 6b7be64
cleanup: remove teal_module_data code that is no longer used
averissimo 1e9696d
docs: rearrange some docs
averissimo 9a547e2
cleanup: small optimizations
averissimo 6373a30
cleanup: consistent call to show/hide
averissimo df110b4
cleanup: remove debugging UI elements
averissimo 8df11e7
fix: too much cleanup
averissimo e3a4f50
feat: use of srv_ and ui_ to validate instead of list
averissimo 2772337
feat: use bquote and splicing
averissimo 6ea756e
feat: improve on stop_on_first implementation
averissimo a7b81fa
chore: move function to oneliner
averissimo 0b31102
chore: minor cleanup
averissimo 45ff32c
chore: fix linter problems
averissimo 0fe809d
docs: remove export
averissimo 25b397a
docs: update
averissimo 8c2fac1
docs: typos
averissimo ac5c67a
docs: out of order
averissimo 47dd8eb
feat: support for in-module validation
averissimo ed10c4d
fix: decorated behavior
averissimo f2341d1
fix: tentative solution for decorated failed original data
averissimo a3b3afd
feat: disable transforms/decorators and show info message when top-le…
averissimo 8ac867e
chore: improve message
averissimo 5fbb215
fix: remove browser
averissimo 6f5fe25
fix: blurred UI
averissimo f52de2b
style: border on accordion with error messages
averissimo 62b53ad
fix: condition
averissimo 308e80a
fix: condition
averissimo 8d86b10
fix: issues with disabling accordions
averissimo 640a890
revert: changes moved to #1515
averissimo c53e820
Merge branch 'main' into 1322_validation@main
averissimo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from deleted file