Change cli order for wait for pvcs in interactive mode #1609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanBoden
requested review from
durera,
andrercm,
sanjayprab,
terenceq,
whitfiea and
alequint
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using interactive cli the wait for pvcs question is asked prior to the non-interactive command is displayed and if answered no the --no-wait-for-pvc flag is added. Added it to the summary in a new section as didn't seem to fit any existing ones.
When using non-interactive cli:
--no-confirm set , --no-wait-for-pvc not set : will wait for PVCs (same as before)
--no-confirm set, --no-wait-for-pvc set : will not wait for PVCs (change from before where it was ignored)
--no-confirm not set --no-wait-for-pvc not set : will ask the question (same as before)
--no-confirm not set --no-wait-for-pvc set : will not wait for PVCs (change from before where the question was asked)
Also fixed the non-interaactive cli output for installing cp4d components as they were getting dropped
Changed makefile as python 3 has been the default modern installers no longer create a python3 link