Protobuf 22.5 cpp #11961
Protobuf 22.5 cpp #11961
Conversation
…the :grpc-compiler:checkArtifacts step
…ose since it doesn't work on multiarch build arch64.
…ule instead of as a package, and this version is not available to install. Hence building cmake from source. Building the latest source of cmake needs openssl location to be specified (or have openssl turned off) so using the older version 3.13.4
…e VS 2022 installation path.
…n't show it even when it is available
…uf progress bar is causing 'access denied error' on windows console: crc-org/crc#1184
…uf progress bar is causing 'access denied error' on windows console: crc-org/crc#1184
…d cmake from source on 64 bit archs.
…ue passed to the command.
…with LIBRARY_PATH still.
…ng the CoreFoundation change for linux.
…y needed to be specified when building the exe.
|
Windows run: fusion/0b0cb5e6-81e6-47ec-982b-ea4ba8d44f23 |
| RUN curl -Ls https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz | \ | ||
| tar xz -C /var/local | ||
|
|
||
| # Install Maven |
There was a problem hiding this comment.
Why add maven? I don't think we use Maven in this container. Ditto for ubuntu2004.base
There was a problem hiding this comment.
Maven was pre-existing (and needed) in Dockerfile. You added it in Dockerfile.multiarch.base and Dockerfile.ubuntu2004.base. Only remove it from the places you added it. The UnsupportedClassVersionError is completely unrelated. The failure was /grpc-java/buildscripts/kokoro/unix.sh: line 74: mvn: command not found
There was a problem hiding this comment.
Done. I wrongly thought the UnsupportedClassVersionError was the cause of the build failure and associated it with the maven install removal commit even though it didn't make logical sense.
buildscripts/make_dependencies.bat
Outdated
| set CMAKE_NAME=cmake-3.3.2-win32-x86 | ||
| echo on | ||
| @rem set PROTOBUF_VER=21.7 | ||
| choco install -y gradle git curl pkgconfiglite |
There was a problem hiding this comment.
We don't use the system-installed gradle, so I don't know why that is here. Git should already be installed; is this some different version of git? What uses curl?
I had thought we were going to be adding these installations to the base image itself. OpenJDK in particular I'm not wild about installed every invocation, as it is relatively large.
There was a problem hiding this comment.
Removed git and gradle. git command is not available in PATH on the VM I worked with even though the build is going through on CI.
compiler/build.gradle
Outdated
| String libsList = rootProject.property('vcProtobufLibs') as String | ||
| libsList.split(',').each() { lib -> linker.args.add(lib) } | ||
| } | ||
| if (rootProject.hasProperty('vcProtobufLibPaths')) { |
There was a problem hiding this comment.
Why do we need this new property? It is the same as vcProtobufLibs; we can just use -PvcProtobufLibs=%VC_PROTOBUF_LIBS%,%VC_PROTOBUF_LIB_PATHS% right?
…pportedClassVersionError after removing it: sponge2/529018d0-cbc5-4ebb-8a7f-959f90d3742d
…e build failure. Reintroducing mvn installation only in Dockerfile and not in multiarch and ubuntu.
No description provided.