Skip to content

Remove Debug trait from service traits #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 11, 2025
Merged

Remove Debug trait from service traits #183

merged 4 commits into from
Apr 11, 2025

Conversation

aneubeck
Copy link
Contributor

@aneubeck aneubeck commented Apr 9, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 07:57
@aneubeck aneubeck requested a review from a team as a code owner April 9, 2025 07:57
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the Debug trait requirement from service client traits.

  • Debug trait has been removed from the trait declaration.
  • The service trait now only requires Send and Sync.

@aneubeck aneubeck enabled auto-merge April 9, 2025 07:58
@aneubeck aneubeck disabled auto-merge April 9, 2025 07:59
@aneubeck @CleanCut
Update crates/twirp-build/Cargo.toml
929ddd2 
Co-authored-by: Nathan Stocks <cleancut@github.com>
@aneubeck aneubeck enabled auto-merge April 11, 2025 10:37
@aneubeck aneubeck added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 204ea4e Apr 11, 2025
5 checks passed
@aneubeck aneubeck deleted the aneubeck/no-debug branch April 11, 2025 10:40
@CleanCut
Copy link
Contributor

This PR was included in v0.8.0, released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanCut CleanCut CleanCut left review comments

Copilot code review Copilot Copilot left review comments

@gorzell gorzell gorzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aneubeck @CleanCut @gorzell