Skip to content

feat(symbolication): get gcp token instead of credentials #91016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented May 6, 2025

This PR adds the GCP token fetching for symbolication to pass it down to symbolicator instead of using credentials.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/lang/native/sources.py 33.33% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (42.85%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91016       +/-   ##
===========================================
+ Coverage   46.15%   87.69%   +41.54%     
===========================================
  Files       10283    10299       +16     
  Lines      583526   584359      +833     
  Branches    22583    22583               
===========================================
+ Hits       269299   512445   +243146     
+ Misses     313797    71484   -242313     
  Partials      430      430               

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant