Skip to content

Update README.md - replace twitter for github accounts #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

froscon2024
Copy link

@froscon2024 froscon2024 commented Sep 22, 2024

Twitter is now X and have bad reputation. Use github accounts instead

Summary by Sourcery

Replace Twitter links with GitHub links in the README.md for the founders' profiles to reflect current preferences.

Documentation:

  • Update README.md to replace Twitter links with GitHub links for the founders' profiles.

Twitter is now X and have bad reputation. Use github accounts instead
Copy link

sourcery-ai bot commented Sep 22, 2024

Reviewer's Guide by Sourcery

This pull request updates the README.md file to replace Twitter links with GitHub links for the FOSSASIA founders. The change is made due to Twitter's rebranding and perceived reputation issues.

File-Level Changes

Change Details Files
Replace Twitter links with GitHub links for FOSSASIA founders
  • Update Mario Behling's profile link from Twitter to GitHub
  • Update Hong Phuc Dang's profile link from Twitter to GitHub
README.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @froscon2024 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The change looks good, but consider using a more neutral and descriptive commit message. For example: 'Update README.md: Replace Twitter links with GitHub profiles for contributors'
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant