Dropdown arrows visibility issue resolved #681
Conversation
|
Here is the screenshot after the changes. |
|
Here is the deployed link. |
css/theme-lava.css
Outdated
| @@ -622,7 +622,6 @@ nav .container { | |||
| -webkit-font-smoothing: antialiased; | |||
| -moz-osx-font-smoothing: grayscale; | |||
| content: "\e688"; | |||
| color: #fff; | |||
| font-size: 24px; | |||
There was a problem hiding this comment.
You have just removed the color property but the default color remains the same i.e.white so No change in UI
There was a problem hiding this comment.
Thank you @mohitm15 and @Chaitanyassr for reviewing my pull request! :)
According to my understanding, the pull request made resolves the issue raised #672
I have attached screenshots and highlighted with a red rectangle, to show reflected changes.
Before
After
I wanted to ask instead of deleting the color property, should I set it to black and update my pull request?
There was a problem hiding this comment.
Change the color accordingly for that particular icon or class instead of deleting it
|
Thankyou @abishekvashok for reviewing my pull request. |
|
Now it looks weird on desktop, please use css breakpoints |
css/theme-lava.css
Outdated
| @@ -622,7 +622,7 @@ nav .container { | |||
| -webkit-font-smoothing: antialiased; | |||
| -moz-osx-font-smoothing: grayscale; | |||
| content: "\e688"; | |||
| color: #fff; | |||
| color: #000000; | |||
There was a problem hiding this comment.
Now it looks weird on desktop, please use css breakpoints
@media screen and (min-width: 480px)
{
color : black;
}
|
Thankyou @abishekvashok and @mohitm15 for reviewing my pull request. |
|
@abishekvashok @mohitm15 @Chaitanyassr kindly review my pull request! I have attached the images highlighting the changes made as requested. Here is the deployed link. |
Fixes #672