Use correct DA transaction compression #61
Conversation
|
@danyalprout please review |
|
Oh, I maybe missed it :) |
|
@danyalprout fixed |
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
4 times, most recently
from
4cb410e to
f9ec955
Compare
| @@ -155,6 +167,16 @@ impl Service for OpRbuilderConfig { | |||
| .arg(flashbots_block_time.to_string()); | |||
| } | |||
|
|
|||
| if let Some(max_da_tx_size) = self.max_da_tx_size { | |||
| cmd.arg("--builder.max-da-tx-size") | |||
There was a problem hiding this comment.
Is this a flag of the builder? I though it is the batcher the one that updates these values.
There was a problem hiding this comment.
Good question
In reth they have rpc call in miner namespace, should we implement the same 🤔
Seems like I need to dig more into DA
There was a problem hiding this comment.
It'll need to be on the RPC, as it changes dynamically when the batcher is congested.
If you ensure the DA Config is shared between the payload builder and the OPAddOnsBuilder it should work (ref) out of the box.
We're running the two closed PR's on Base Sepolia (and briefly Base Mainnet) last week and it successfully was able to throttle on both networks.
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
from
be4d330 to
886a7de
Compare
|
@ferranbt @danyalprout |
Fix DA config, set it via miner Extend tests Add op-alloy-flz dependency and update related configurations - Added `op-alloy-flz` as a dependency in `Cargo.toml` and `Cargo.lock`. - Configured `op-alloy-flz` to be part of the workspace in `op-rbuilder`'s `Cargo.toml`. - Updated the `payload_builder_vanilla.rs` to utilize `op-alloy-flz` for transaction size estimation. - Enhanced test framework to include new data availability tests ensuring block size limits are respected. Add max data availability transaction and block size configuration - Introduced `max_da_tx_size` and `max_da_block_size` fields in `TestHarnessBuilder` and `OpRbuilderConfig`. - Added builder methods `with_max_da_tx_size` and `with_max_da_block_size` for setting these values. - Implemented a new test to ensure transaction size limits are respected in data availability scenarios. - Updated test module to include the new data availability test. Add cumulative_da_bytes_used accur Add da config Use correct DA transaction compression
SozinM
force-pushed
the
msozin/use-tx-da-compression
branch
from
886a7de to
4643203
Compare
📝 Summary
Supersedes #7 and #8
Added some extra integration tests for txpool
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test