Send getPayload request to all relays again #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
approved these changes
May 1, 2025
metachris
reviewed
May 2, 2025
|
|
||
| // Check if the relay supports SSZ | ||
| relaySupportsSSZ := false | ||
| for _, originalBidRelay := range originalBid.relays { |
There was a problem hiding this comment.
this would be better as a simple map lookup
There was a problem hiding this comment.
It cannot be a simple map lookup though. Because the SSZ field might be different.
metachris
reviewed
May 2, 2025
|
|
||
| // If the relay provided the bid in JSON or did not provide a bid for this payload, | ||
| // we must convert the signed blinded beacon block from SSZ to JSON for this relay | ||
| if parsedProposerContentType == MediaTypeOctetStream && !relaySupportsSSZ { |
There was a problem hiding this comment.
not ideal to convert this again for every relay that would need it. would be better to check up-front if any relay will need it, and then prepare it once for all
There was a problem hiding this comment.
I disagree. The conversion is quick. Let's just send out the SSZ requests as soon as possible.
metachris
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Instead of only sending the getPayload request to relays which provided this bid, send the getPayload request to all relays and convert the signed blinded beacon block to JSON if necessary.
⛱ Motivation and Context
In theory, this should improve liveness. If, for example, there is a relay which is geographically closes to the proposer, it might get the getPayload request sooner and therefore it would distribute the block faster.
📚 References
https://discord.com/channels/595666850260713488/1341434255154348034/1367203484620947508
✅ I have run these commands
make lintmake test-racego mod tidy