fix(go/genkit): expose detailed 4xx errors in googlegenai plugin #2853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoaguirre
requested changes
May 6, 2025
- Add strict format validation to prevent silent 4xx errors - Add detailed error handling for HTTP status codes 400, 401, 403, 429, 500 - Fix issue where invalid API keys would fail with unhelpful errors - Document API's unusual behavior with invalid credentials
Remove unnecessary validation in favor of SDK's built-in validation. The Google AI and Vertex AI plugins now rely on the SDK to validate credentials, avoiding redundant validation steps. Add error formatting for better error messages. API errors are now properly formatted with clear, human-readable messages for common HTTP status codes. Ensure errors are properly propagated to callers instead of being swallowed. This makes debugging easier and provides better feedback to end users.
hugoaguirre
reviewed
May 9, 2025
There was a problem hiding this comment.
You can ignore the changes in this file
There was a problem hiding this comment.
I can remove it. But the original won't take signal to exit by pressing Ctrl + C.
hugoaguirre
reviewed
May 9, 2025
| @@ -327,6 +327,7 @@ func generate( | |||
| // Extract configuration to get the model version | |||
| config, err := configFromRequest(input) | |||
| if err != nil { | |||
| // This is a local error from config parsing, not an API error | |||
There was a problem hiding this comment.
nit: not needed (same for the rest of the comments)
There was a problem hiding this comment.
The reason I add comments is to distinguish API error and none API error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log.Printfandfmt.ErrorfinjokesFlowto log detailed errors.Tested with an invalid API key, producing:
Generate error: Error 400, Message: API key not valid...
Checklist (if applicable):