Skip to content

Make withStackSave not internal #24277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make withStackSave not internal #24277

wants to merge 1 commit into from

Conversation

hoodmane
Copy link
Collaborator

@hoodmane hoodmane commented May 7, 2025

Resolves #24275

@hoodmane hoodmane force-pushed the withStackSave-not-internal branch from f7d3867 to 7764b70 Compare May 7, 2025 19:09
@hoodmane hoodmane mentioned this pull request May 7, 2025
Open
sbc100
sbc100 approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Perhaps we should open two followup issues:

  1. -sEXPORTED_FUNCTIONS should not work on __internal symbols
  2. When -sEXPORTED_FUNCTIONS or -sEXPORTED_RUNTIME_METHODS includes and internal function it should say why it doesn't work.

@sbc100
Copy link
Collaborator

sbc100 commented May 7, 2025

Whenever a new non-internal library function is added the unoptimized code size expectations will change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined exported symbol: "withStackSave" in EXPORTED_RUNTIME_METHODS
2 participants
@hoodmane @sbc100