Skip to content

Add user_may_create_room_with_visibility spamchecker module API callback #18455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented May 19, 2025

WIP

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@github-actions github-actions bot deployed to PR Documentation Preview May 19, 2025 13:02 Active
@@ -289,6 +290,20 @@ async def on_PUT(

content = parse_json_object_from_request(request)

if event_type == EventTypes.JoinRules:
visibility = "public" # XXXTODO: determine visibility from content
spam_check = await self._spam_checker_module_callbacks.user_may_create_room_with_visibility(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be preferable from a module API point of view to separate room creation from changing visibility.

For changing visibility it might make sense to be:

user_may_change_visibility(user_id: str, room_id: str, old_visibility: str, new_visibility: str)

But, that might also be over complicating things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant