Stop sending or processing the origin field in PDUs

[anoadragon453]

To align with this change in Matrix v1.12. Addresses part of #18118.

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Code style is correct
  (run the linters)

[3nprob]

Is the intention to actually eventually remove this or why is it retained? Is there a functional reason why it's still being retained?

[anoadragon453]

The contrib/graph/graph.py is not a tool maintained by the core development team (as is anything else under contrib/), hence me not changing it.

But we'd accept a PR that updates the tool to remove that bit.

[3nprob]

Bystander Q to understand intended scope and direction: Will the references to origin in PDU processing and storage f.e. in _process_incoming_pdus_in_room_inner also be intended legacy/deprecated/get removed or would that be unrelated to the changes here?

[anoadragon453]

Bystander Q to understand intended scope and direction: Will the references to origin in PDU processing and storage f.e. in _process_incoming_pdus_in_room_inner also be intended legacy/deprecated/get removed or would that be unrelated to the changes here?

That "origin" is referring to the origin field on PUT /_matrix/federation/v1/send/{txnId}, which is unrelated to this PR.

Also note the origin attribute of X-Matrix federation authentication headers, which too is separate.

[anoadragon453]

Converting to draft while CI is still failing.

[3nprob]

Bystander Q to understand intended scope and direction: Will the references to origin in PDU processing and storage f.e. in _process_incoming_pdus_in_room_inner also be intended legacy/deprecated/get removed or would that be unrelated to the changes here?

That "origin" is referring to the origin field on PUT /_matrix/federation/v1/send/{txnId}, which is unrelated to this PR.

Also note the origin attribute of X-Matrix federation authentication headers, which too is separate.

Thanks for clarifying!