[StyleCleanUp] Use literals where appropriate (CA1802) #10725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10725 +/- ##
===================================================
- Coverage 11.25778% 11.20563% -0.05216%
===================================================
Files 3315 3313 -2
Lines 665229 665139 -90
Branches 74668 74668
===================================================
- Hits 74890 74533 -357
- Misses 589035 589307 +272
+ Partials 1304 1299 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've prepared this PR but then just realized that #10382 needs to be done first to prevent havoc, so gonna draft this.
Fixes #10724
Description
Swaps use of
static readonlyfields forconstwhere appropriate. This in some cases saves allocations.Note that naming issues will be taken care of in a separate issue to reduce diffs.
Customer Impact
Decreased allocations, a bit of perf.
Regression
No.
Testing
Local build.
Risk
Low, just an analyzer fix. The only issue would be reflection-based changes that will no longer be possible but there's no point of supporting these anyways, we'd never move anywhere.
Microsoft Reviewers: Open in CodeFlow