Skip to content

Remove WinRT ReflectionHelper dead code (compiled, not used) #10666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 28, 2025

Description

Removes the ReflectionHelper static class from the WindowsRuntime namespace. We do use ReflectionHelper, but that's one put in System.Windows.Markup that's used pretty much by all libraries and is a different from this impl.

This one popped up in netfx4 during the inclusion of WinRT into the codebase but wasn't used.

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

None, unused dead code.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 28, 2025 10:46
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.47840%. Comparing base (b7f5416) to head (fb8ef94).
Report is 2 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10666         +/-   ##
===================================================
- Coverage   13.71795%   13.47840%   -0.23955%     
===================================================
  Files           3317        3316          -1     
  Lines         665537      665435        -102     
  Branches       74666       74655         -11     
===================================================
- Hits           91298       89690       -1608     
- Misses        571542      573145       +1603     
+ Partials        2697        2600         -97     
Flag Coverage Δ
Debug 13.47840% <ø> (-0.23955%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siagupta0202
Copy link
Contributor

LGTM, @h3xds1nz can you resolve the merge conflicts?

@h3xds1nz h3xds1nz force-pushed the remove-winrt-reflection branch from 8221af4 to fb8ef94 Compare April 24, 2025 11:13
@h3xds1nz
Copy link
Member Author

@siagupta0202 Done :)

@siagupta0202 siagupta0202 merged commit 2a6fbf6 into dotnet:main Apr 25, 2025
8 checks passed
@siagupta0202
Copy link
Contributor

@h3xds1nz Thank you so much for your contributions!

@h3xds1nz
Copy link
Member Author

@siagupta0202 Thanks you :) Now we just need to process #10667 haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants