Skip to content

feat: Quality of life changes under the "Eval arguments" header of the Sharding section #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

heavylightdecomp
Copy link

Please describe the changes this PR makes and why it should be merged:
Reading the content about Sharding, I felt that it takes quite a while for a user who has just been redirected to the "Eval arguments" header from this link to pick up what is going on.

Therefore, the following changes were made to the Eval arguments section:

  • changed the name of funcName parameters to make it more clear what is being passed
  • Added some newlines to make the usage of .broadcastEval more clear
  • Added another sentence to help with the logical flow of the section.
  • Added an additional tip that points users to further usage of .broadcastEval

In my opinion it's ready for review. If there are any objections about the changes I've made I'm happy to fix them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant