Skip to content

Set dynamic field for GET method only #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set dynamic field for GET method only #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63a9128
Set dynamic field for get method only
dwisulfahnur Mar 26, 2019
f0da1a1
Merge pull request #1 from dwisulfahnur/set-get-method-only
dwisulfahnur Mar 26, 2019
509e1e8
Fix unused indent
dwisulfahnur Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drf_dynamic_fields/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ def fields(self):
warnings.warn('Context does not have access to request. '
'See README for more information.')
return fields

# Dynamic fields must be used for GET method only
if request.method != 'GET':
return fields

# NOTE: drf test framework builds a request object where the query
# parameters are found under the GET attribute.
Expand Down