Skip to content

Implement asyncio-compatible Schema Registry client #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: refactor-for-async-support
Choose a base branch
from

Conversation

rohitsanj
Copy link

@rohitsanj rohitsanj commented Apr 10, 2025

What

  • Converted the existing sync Schema Registry clients to be made async and placed them in the _async module.
  • The code was converted such that it could be made sync by simply applying some regular expression driven replace logic (like await func(x, y, z) -> func(x, y, z), AsyncXYZ -> XYZ and so on). Going forward, all diffs must be solely made to the _async module, the sync clients will be derived from the async clients.
  • The same treatment is applied to the tests, any new async test written must work with async keywords removed.

This PR is still in draft because we're still exploring adding async support as a whole to the library.


Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@airlock-confluentinc airlock-confluentinc bot force-pushed the add-async-compat-schema-registry branch from 30156d9 to 920ddb6 Compare April 17, 2025 21:40
@rohitsanj rohitsanj changed the base branch from master to refactor-for-async-support April 17, 2025 21:42
@airlock-confluentinc airlock-confluentinc bot force-pushed the refactor-for-async-support branch from cd95e33 to bd445fd Compare April 17, 2025 21:59
@airlock-confluentinc airlock-confluentinc bot force-pushed the add-async-compat-schema-registry branch from 036451a to 1fe184e Compare April 21, 2025 18:22
@rohitsanj rohitsanj mentioned this pull request Apr 23, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant