Skip to content

Remove redundant checks #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

pavlovdog
Copy link

@pavlovdog pavlovdog commented Feb 13, 2024

Overview

Allow packed array to be empty

The previous version did not allow packed fields to be empty, which is a common case (example).

Allow fields to be encoded in order other than monotonically increasing

In case the field order is correct, but data is being encoded in another order (example, same scheme but with upgraded scheme), decoding was failing.

Update Makefile

Made test results more explicit

PASS: test/pass/all_features
PASS: test/pass/import
PASS: test/pass/nested_enum
PASS: test/pass/nested_message
PASS: test/pass/no_message
PASS: test/pass/only_primitives
PASS: test/pass/repeated_uint64
PASS: test/pass/uint64
--sol_out: unsupported field type TYPE_DOUBLE: Message.field
PASS (expected to fail): test/fail/double
empty_enum.proto:3:6: Enums must contain at least one value.
PASS (expected to fail): test/fail/empty_enum
--sol_out: messages must have at least one field: EmptyMessage
....

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

- Allow packed array to be empty
- Allow fields being encoded in order other than monotonically increasing
- Make test results more explicit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant