-
Notifications
You must be signed in to change notification settings - Fork 122
HelpersTask597_Configure_Codecov_for_coverage #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HelpersTask597_Configure_Codecov_for_coverage #598
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Some comments.
dev_scripts_helpers/update_devops_packages/notebooks/Master_buildmeister_dashboard.ipynb
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/update_devops_packages/notebooks/Master_buildmeister_dashboard.ipynb
Outdated
Show resolved
Hide resolved
dev_scripts_helpers/update_devops_packages/notebooks/Master_buildmeister_dashboard.py
Show resolved
Hide resolved
…b.com:causify-ai/helpers into HelpersTask597_Configure_Codecov_for_coverage
…b.com:causify-ai/helpers into HelpersTask597_Configure_Codecov_for_coverage
@Shaunak01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. Just some nits and comments.
…b.com:causify-ai/helpers into HelpersTask597_Configure_Codecov_for_coverage Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we merge
Pre-commit checks: - 'check_master' passed - 'check_author' passed - 'check_file_size' passed - 'check_python_compile' passed - 'check_gitleaks' passed All checks passed ✅
@dremdem I have run the linter not sure abt the error. The files are linted
|
I ran the
Found some info Tried that approach:
But no luck. Feel free to file a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let’s address a few nits, and feel free to ask Samarth for a review.
Let's merge this and then we do another iteration. We can't have PRs in review for 2 weeks. We want to maintain high tempo |
Issue: #597