fix : added proper error handling to failure logs #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,16 +73,17 @@ export async function retrieveSessionFailures( | |||
| }, | |||
| }); | |||
|
|
|||
| await assertOkResponse(response, "session logs"); | |||
| const validationResult = validateLogResponse(response, "session logs"); | |||
There was a problem hiding this comment.
Suggested change
| const validationResult = validateLogResponse(response, "session logs"); | |
| const validationError = validateLogResponse(response, "session logs"); |
do this in all places
src/tools/getFailureLogs.ts
Outdated
| logs.length > 0 | ||
| ? `Network Failures (${logs.length} found):\n${JSON.stringify(logs, null, 2)}` | ||
| : "No network failures found", | ||
| response.message || |
There was a problem hiding this comment.
directly return the result of these conditionals in the response (for other methods as well)
There was a problem hiding this comment.
Can you explain this change a bit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where an error in fetching one type of logs was disrupting the retrieval of all log types.