Skip to content

Fixed issue: Can't go back to page 1 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed issue: Can't go back to page 1 #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebbfa61
fixed TypeError: Cannot read property 'width' of undefined
ykchan97 Oct 21, 2020
3dfd25d
fix can't go back to page 1 issue
ykchan97 Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Carousel/Carousel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,9 @@ export default {
this.maxPages = this.slidesWidth.findIndex(({ offsetLeft }) => offsetLeft > maxPos) - 1
},
calcNextWidth(direction) {
const nextSlideIndex = direction > 0 ? this.currentPage : this.currentPage + direction
const nextSlideIndex = Math.max( direction > 0 ? this.currentPage : this.currentPage + direction, 0)
// Don't use ES6 destructing - reduce bundle size
const width = this.slidesWidth[nextSlideIndex].width || 0
const width = nextSlideIndex >=0 && this.slidesWidth[nextSlideIndex].width || 0

if (!width) {
return
Expand Down