Skip to content

chore: fix incorrect comparison operators #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix incorrect comparison operators #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/stepfunctions/steps/sagemaker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ def __init__(self, state_id, estimator, job_name, data=None, hyperparameters=Non
else:
training_parameters = training_config(estimator=estimator, inputs=data, mini_batch_size=mini_batch_size)

if estimator.debugger_hook_config != None and estimator.debugger_hook_config is not False:
if estimator.debugger_hook_config is not None and estimator.debugger_hook_config is not False:
training_parameters['DebugHookConfig'] = estimator.debugger_hook_config._to_request_dict()

if estimator.rules != None:
if estimator.rules is not None:
training_parameters['DebugRuleConfigurations'] = [rule.to_debugger_rule_config_dict() for rule in estimator.rules]

if isinstance(job_name, Placeholder):
Expand Down
2 changes: 1 addition & 1 deletion src/stepfunctions/steps/states.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def next(self, next_step):
# By design, Choice states do not have the Next field. When used in a chain, the subsequent step becomes the
# default choice that executes if none of the specified rules match.
# See language spec for more info: https://states-language.net/spec.html#choice-state
if self.type is 'Choice':
if self.type == 'Choice':
if self.default is not None:
logger.warning(f'Chaining Choice state: Overwriting {self.state_id}\'s current default_choice ({self.default.state_id}) with {next_step.state_id}')
self.default_choice(next_step)
Expand Down